Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truck travel time matrices and refactor matrix getting #439

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Fix truck travel time matrices and refactor matrix getting #439

merged 3 commits into from
Feb 10, 2022

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented Feb 7, 2022

Hide matrix adjustments in _get_matrices function.

zptro
zptro commented Feb 7, 2022
View reviewed changes
Scripts/assignment/assignment_period.py
Comment on lines +431 to +432
if mtx_type == "time" and subtype in param.assignment_modes:
mtx = self._extract_timecost_from_gcost(subtype)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual bug fix.

@zptro zptro linked an issue Feb 7, 2022 that may be closed by this pull request
Travel time is not written to matrices for vans, trucks and trailer trucks #432
Closed
@zptro zptro requested a review from johpiip February 7, 2022 10:10
johpiip
johpiip approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travel times are written to result matrices now, so everything seems to be working!

@zptro zptro merged commit d66f696 into olusanya Feb 10, 2022
@zptro zptro deleted the hotfix/truck_travel_time_matrices branch February 10, 2022 07:10
johpiip added a commit that referenced this pull request Feb 18, 2022
@johpiip
Fix truck travel time matrices and refactor matrix getting (#439) (#444)
43b8342 
* Refactor matrix getting

* Refactor further

* Change function name

Co-authored-by: Jens West <jens.west@hsl.fi>
johpiip added a commit that referenced this pull request Feb 18, 2022
@johpiip
Fix truck travel time matrices and refactor matrix getting (#439) (#445)
4b31de4 
* Refactor matrix getting

* Refactor further

* Change function name

Co-authored-by: Jens West <jens.west@hsl.fi>
@zptro zptro mentioned this pull request Mar 2, 2022
Merged
@zptro zptro added this to the v4.1.1 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johpiip johpiip johpiip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1.1
Development

Successfully merging this pull request may close these issues.

Travel time is not written to matrices for vans, trucks and trailer trucks
2 participants
@zptro @johpiip